Re: [PATCH] Make the exit code of add_file_to_index actually useful

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Alex Riesen <raa.lkml@xxxxxxxxx> writes:

> Junio C Hamano, Tue, May 13, 2008 00:19:42 +0200:
> ...
>> I would understand there can be some files that cannot be read.  But when
>> there is such a file, why is it Ok to ignore an error to update the
>> contents from that file if/when the user asks to index the current
>> contents, provided if the contents of that file is to be tracked?  Isn't
>> it the true cause of the problem that the file is being tracked but it
>> shouldn't?
>
> No, I don't think so. Consider "git add dir/". It is _not_ 1 (one)
> operation. It is many operations (add every file in the "dir/"). Why
> should all of them be considered failed just because the third file
> from the bottom could not be read (and the user may have not even seen
> it, because it wasn't there before, like a temporary file from Excel).
> And for a user (for me, at least) "git add" is an intermediate
> operation anyway...

Ah, Ok, I was overly cautious, and the worry is unfounded, as long as you
do not trigger this "ignore" thing upon "git commit -a".

Thanks.  Will queue.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux