Alex Riesen <raa.lkml@xxxxxxxxx> writes: > Junio C Hamano, Sun, Mar 02, 2008 17:59:13 +0100: >> Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: >> > On Sun, 2 Mar 2008, Alex Riesen wrote: >> > >> >> - add_file_to_cache(path, verbose); >> >> + if (add_file_to_cache(path, verbose)) >> >> + exit(1); >> > >> > Does it really, really _have_ to be exit(1)? I mean, now you block even >> > the faintest chance that we can libify libgit.a by overriding die_routine. >> >> I think Alex did so not to break the existing scripts that rely on these >> dying, but it should have been exit(128) to really stay compatible. > > I corrected the series to use die() again and rebased it off current > master (65ea3b8c). So it is more compatible with libification (does > not hinder it more than previos code) and keep the exit code. But you did not answer my question in the part you did not quote, did you? Now when somebody either forgets to check the return value from this function, or deliberately ignores it, the resulting index will not match what the code is told to update it with. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
