Hi, On Sun, 2 Mar 2008, Alex Riesen wrote: > - add_file_to_cache(path, verbose); > + if (add_file_to_cache(path, verbose)) > + exit(1); Does it really, really _have_ to be exit(1)? I mean, now you block even the faintest chance that we can libify libgit.a by overriding die_routine. A "return -1" might make _much_ more sense, too. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html