On Sun, 2 Mar 2008, Johannes Schindelin wrote: > Hi, > > On Sun, 2 Mar 2008, Alex Riesen wrote: > > > - add_file_to_cache(path, verbose); > > + if (add_file_to_cache(path, verbose)) > > + exit(1); > > Does it really, really _have_ to be exit(1)? I mean, now you block even > the faintest chance that we can libify libgit.a by overriding die_routine. It would be handy to have a die_no_message(), for cases like this where a function wants to print an error message but it's up to the caller whether to abort (in the contextually reasonable way). -Daniel *This .sig left intentionally blank* -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
