Re: [StGit PATCH 0/6] Two bugfixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2008-03-25 10:46:00 +0000, Catalin Marinas wrote:

> My reason for this is that usually you "goto" a patch to do some
> changes followed by "refresh". If there were local changes, they
> would be included in the refreshed patch since this is the default
> StGIT behaviour. To avoid this, I find myself running "status"
> before any "goto".

Yeah, I can see how that would be irritating. Especially since the
conversion to the new infrastructure is only half done, so that not
all commands behave the same.

> But in git, for committing, you usually need to run "git add" on the
> files or specify "commit -a" explicitly. We would need to change the
> "refresh" behaviour in the same way and, in this case, I would be OK
> with (2) as the default.
>
> I personally prefer the current "refresh" way but maybe because I'm
> used to it. It would be useful to get other users' opinion on this
> UI change. Might not be a bad change since git does this already,
> quilt needs an explicit "add" (anyone knows about guilt?).

I think my preference would be to to what git does: let just "stg
refresh" commit what's in the index, and have "stg refresh -a" or
something to automatically update the index first. (This should be
easy to do, btw -- refresh already has an --index flag.)

In general, I think it's a bad idea to do things differently from git
without a good reason.

-- 
Karl Hasselström, kha@xxxxxxxxxxx
      www.treskal.com/kalle
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux