Brandon Casey wrote: > Johannes Schindelin wrote: >> Hi, >> >> On Mon, 24 Mar 2008, Junio C Hamano wrote: >> >>> Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: >>> >>>> On Sun, 23 Mar 2008, Junio C Hamano wrote: >>>> >>>>> If you tell filter-branch to filter a branch A and a tag T, as the >>>>> command is advertised to rewrite positive refs that were given from >>>>> the command line, isn't it natural to expect that the command would >>>>> attempt its best effort to rewrite such a tag object? >>>> The thing is: signed tags cannot be rewritten. >>> I know that, and you know I know that if you read what you responded >>> again ;-) >>> >>> And I think stripping of gpg signature part is a reasonable best effort >>> for the command, _when_ the user told a signed tag to be rewritten. >> Yes. >> >> BUT. >> >> You can say "--all", and I actually expect quite a few people to do >> exactly that. And then you cannot really say "the user explicitely asked >> to have that signed tag rewritten". > > That sounds like saying that specifying "HEAD" as the revision (_and_ > using --tag-name-filter) is not explicitly asking for tags to be rewritten. Maybe that should be qualified. I think your statement is similar to my example and so "not explicitly asking for tags" (by your definition) since neither explicitly named the tags to be rewritten on the command line. In both cases, tag objects would currently be replaced by lightweight tags when --tag-name-filter is used. -brandon -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
