Jeff King schrieb: > On Thu, Mar 13, 2008 at 02:59:08PM +0100, Johannes Sixt wrote: > >>> + status = run_command_v_opt(argv, 0); >> ... >>> + return status == 0 ? 1 : -1; >> grep can return 0 (success, something found), 1 (nothing found), and other >> values for "real" failures like usage errors or crashes. This conditional >> throws the latter two into the same pot, which makes git-grep unable to >> distinguish "nothing found" from failure; cf. the call sites of >> flush_grep(), where want to set the flag 'hit'. > > I noticed that, as well, while writing it. But if you look at > external_grep, it just lumps the two cases together anyway. It only ever > compares "0 < status", so I think the behavior should be identical. Yes, indeed. I missed that status < 0 is not checked for. -- Hannes -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
