Ping Yin schrieb: > + memset(&sm_summary, 0, sizeof(sm_summary)); > + sm_summary.argv = argv; > + sm_summary.env = env; > + sm_summary.git_cmd = 1; > + sm_summary.no_stdin = 1; > + fflush(s->fp); > + sm_summary.out = dup(fileno(s->fp)); /* run_command closes it */ The fflush() at this point makes a lot of sense, and doesn't even need a comment (IMHO). > wt_status_print_changed(s); > + // must flush s->fp since following call will write to s->fp in a child process > + fflush(s->fp); > + wt_status_print_submodule_summary(s); > wt_status_print_untracked(s); But then we don't need the fflush() here. Right? -- Hannes -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html