Jeff King schrieb: > Previously, we just chose whether to allow external grep > based on the __unix__ define. However, there are systems > which define this macro but which have an inferior group > (e.g., one that does not support all options used by t7002). > This allows users to accept the potential speed penalty to > get a more consistent grep experience (and to pass the > testsuite). > > Signed-off-by: Jeff King <peff@xxxxxxxx> > --- > This might have fallouts for msysgit (i.e., they need to define > NO_EXTERNAL_GREP instead of relying on __unix__ not being defined). You name it. Would you mind converting exec_grep() to use run_command(), too? Or better inline it since it won't do a lot more than run_command()? That way we at least won't get a broken git when I merge git.git that has this patch. Thanks, -- Hannes -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
