On Wed, Mar 12, 2008 at 03:30:05PM -0700, Junio C Hamano wrote: > Perhaps place > > #ifndef NO_EXTERNAL_GREP > #ifndef __unix__ > #define NO_EXTERNAL_GREP 1 > #else > #define NO_EXTERNAL_GREP 0 > #endif > #endif > > in git-compat-util.h, and make the in-code reference to > > #if NO_EXTERNAL_GREP > ... optimization using external grep ... > #endif I agree that is much nicer. Looks like you have already marked it up in pu; what is there looks sane. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html