Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > On Fri, 7 Mar 2008, Junio C Hamano wrote: > >> This miniseries cleans up the interface by making get_pathspec() to die >> again. > > We have a few places where you have to pass a "die_on_error" flag. Why > not imitate that? Before get_pathspec() was made absolute-path capable, it died on a path that is outside the work tree, so we know die() there is what the callers have expected all along. This miniseries is about fixing the earlier one that broke that expectation, nothing more. If enough callers want different behaviours on error, it probably is worth an API enhancement so that the callers can choose to do their own thing, but that is a separate topic I haven't seen the need for, and definitely is not part of this fix. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
