Re: [PATCH 0/4] Re-fix get_pathspec()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri, 7 Mar 2008, Junio C Hamano wrote:

> After 1.5.4, we improved get_pathspec() to allow absolute paths, because
> people wanted to cut&paste from file managers and such, so that you can
> feed absolute paths to "git add" and friends.
> 
> However, the paths still must be inside work tree, so there must be a 
> way to ensure that.  d089eba (setup: sanitize absolute and funny paths 
> in get_pathspec()) botched the interface, by making the check the 
> responsibility of the callers, while keeping the interface to the 
> function intact, which meant that the callers needed to count returned 
> pathspecs and compared it with the number of paths fed to the function.
> 
> This miniseries cleans up the interface by making get_pathspec() to die
> again.

We have a few places where you have to pass a "die_on_error" flag.  Why 
not imitate that?

Ciao,
Dscho

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux