After 1.5.4, we improved get_pathspec() to allow absolute paths, because people wanted to cut&paste from file managers and such, so that you can feed absolute paths to "git add" and friends. However, the paths still must be inside work tree, so there must be a way to ensure that. d089eba (setup: sanitize absolute and funny paths in get_pathspec()) botched the interface, by making the check the responsibility of the callers, while keeping the interface to the function intact, which meant that the callers needed to count returned pathspecs and compared it with the number of paths fed to the function. This miniseries cleans up the interface by making get_pathspec() to die again. Junio C Hamano (4): get_pathspec(): die when an out-of-tree path is given Revert part of 744dacd (builtin-mv: minimum fix to avoid losing files) Revert part of 1abf095 (git-add: adjust to the get_pathspec() changes) Revert part of d089eba (setup: sanitize absolute and funny paths in get_pathspec()) builtin-add.c | 12 ------------ builtin-ls-files.c | 11 +---------- builtin-mv.c | 6 +----- setup.c | 2 ++ t/t3101-ls-tree-dirname.sh | 2 +- t/t7010-setup.sh | 7 ++++--- 6 files changed, 9 insertions(+), 31 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html