Johannes Schindelin schrieb: > On Tue, 18 Dec 2007, Johannes Sixt wrote: >> Johannes Schindelin schrieb: >>> I'd be cautious about using poll(). AFAIK MacOSX 10.2.8 does not have >>> poll(), and IIRC I had problems finding it in MinGW, too. I know, we >>> use it in daemon, upload-archive and upload-pack, but these are not >>> typically functions performed by a client, so I would not know if it >>> worked on my (now-dead) iBook, or on msysGit. >> So what? If we use poll() already in daemon, upload-archive and >> upload-pack, and no MacOSX 10.2.8 user has spoken up with a proposal for >> replacement, then yet another use won't raise a complaint, either. > > daemon, upload-archive and upload-pack are server-side functions, so they > are substantially less well tested. upload-pack is used for local fetches and, therefore, should be well-tested on all systems. >> And if it were a problem for msysGit, I wouldn't have suggested it ;) >> The particular use in pager.c would be inside #ifndef __MINGW32__ #endif >> anyway. > > We still did not integrate the 'daemon' branch of 4msysgit, correct? No, we didn't. -- Hannes - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
