On Wed, Dec 12, 2007 at 09:02:11PM +0100, Pierre Habouzit wrote: > On Wed, Dec 12, 2007 at 06:01:48PM +0000, Eric Wong wrote: > > Junio C Hamano <gitster@xxxxxxxxx> wrote: > > > Hmph. That's reverting this: > > > > > > commit 4c5cf8c44ce06a79da5bafd4a92e6d6f598cea2e > > > Eric, care to comment? > > > > I used to make a statically linked binary package for working on an > > ancient box that didn't have a lot of libraries I wanted, and I probably > > just called `make install' into DESTDIR as a single step without calling > > `make' alone without DESTDIR argument, or I had DESTDIR set in > > config.mak > > Actually this fact generated a bug in debian packaging because git is > built then installed twice in different DESTDIRS, then parts of the > install is pruned (the two installs are arch-dependant and > arch-independant files install so it's a very good reason in term of > packaging). > > The fact that perl.mak caches the DESTDIR make it install things in > the wrong place because it doesn't honour make DESTDIR=foo install and > always use the cached value instead, which is wrong. > > I think Gerrit won't care if it's cached or not, he just cares that it > still honours environment if present. Yes, precisely. Thanks, Gerrit. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html