Hi, On Tue, 18 Dec 2007, Johannes Sixt wrote: > Junio C Hamano schrieb: > > "H.Merijn Brand" <h.m.brand@xxxxxxxxx> writes: > > > >> On Mon, 17 Dec 2007 13:00:22 -0800, Junio C Hamano <gitster@xxxxxxxxx> wrote: > >> > >>> "H.Merijn Brand" <h.m.brand@xxxxxxxxx> writes: > >>> > >>>> HP-UX does not have select.h, but it offers all select () > >>>> functionality. The defines are in <sys/types.h> and <X11/fd.h> > >>> Will apply the patch as-is for now, only because I do not want major > >>> surgery during rc period, but I think is can be improved. > >> ... > >>> Besides, isn't _HPUX_SOURCE a feature-test macro? Feature test > >>> macros > >> That is defined in GNU gcc. I did not pass it with -D... > > > > Actually I changed my mind. I won't be applying this as is. > > > > For the selective inclusion of <sys/select.h>, I would prefer it see > > it done like the attached. > > Is select() actually needed? The one instance in pager.c can easily be > replaced by poll(), which I've already done in my own tree. The other > one in http.c is only used as a timer, but I don't know how to get rid > of that. Maybe a setitimer()/pause() combo? I'd be cautious about using poll(). AFAIK MacOSX 10.2.8 does not have poll(), and IIRC I had problems finding it in MinGW, too. I know, we use it in daemon, upload-archive and upload-pack, but these are not typically functions performed by a client, so I would not know if it worked on my (now-dead) iBook, or on msysGit. Ciao, Dscho - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
