Re: [PATCH] Do check_repository_format() early

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:

> On Thu, 29 Nov 2007, Nguyen Thai Ngoc Duy wrote:
>
>> The comment is clearly not clear enough. Maybe this?
>> 
>> +                     if (!work_tree_env) {
>> +                             retval = set_work_tree(gitdirenv);
>> +                             /* config may override worktree (see
>> set_work_tree comment) */
>> +                             check_repository_format();
>> +                             return retval;
>> +                     }
>
> Perfect.  Please make it so, and add my ACK.

Looks sensible, but can this be accompanied with a trivial test to
demonstrate the existing breakage?
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux