Re: [PATCH] Do check_repository_format() early

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Wed, 28 Nov 2007, Nguyễn Thái Ngọc Duy wrote:

> @@ -246,8 +246,13 @@ const char *setup_git_directory_gently(int *nongit_ok)
>  			static char buffer[1024 + 1];
>  			const char *retval;
>  
> -			if (!work_tree_env)
> -				return set_work_tree(gitdirenv);
> +			if (!work_tree_env) {
> +				retval = set_work_tree(gitdirenv);
> +				/* config may override worktree */
> +				check_repository_format();
> +				return retval;
> +			}
> +			check_repository_format();

Why not move this check before the if?  Other than that, ACK.

Ciao,
Dscho

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux