Re: [PATCH v2] trace2: prevent segfault on config collection where no value specified

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 23, 2025 at 1:02 PM Junio C Hamano <gitster@xxxxxxxxx> wrote:
>
> "D. Ben Knoble" <ben.knoble@xxxxxxxxx> writes:
>
> > I was curious what changed, so I found 792a3850fa (trace2: prevent
> > segfault on config collection with valueless true, 2025-01-10) and I
> > noticed this:
> >
> > -       redacted = redact_arg(value);
> > +       redacted = value ? redact_arg(value): NULL;
>
> Oh, I do not think I tweaked any of the code, other than fixing the
> new test that was not properly formatted.  Mostly I touched up the
> log message.

I could have been clearer—I think this was in the original. I just
happened to notice it because I was curious about what touch-ups you
performed :)



-- 
D. Ben Knoble





[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux