On Wed, Jan 22, 2025 at 1:18 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Junio C Hamano <gitster@xxxxxxxxx> writes: > > > Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > > > >> > >> This patch looks good to me! > > > > Thanks. As I punted on reviewing the tgt_perf part, it is very good > > to see somebody else step in to look it over. > > > > Will queue. > > The test part used broken indentation and also the use of > test_when_finished was careless, so I'll touch it up before queuing. > > No need to resend. > > Thanks. > I was curious what changed, so I found 792a3850fa (trace2: prevent segfault on config collection with valueless true, 2025-01-10) and I noticed this: - redacted = redact_arg(value); + redacted = value ? redact_arg(value): NULL; I think I expected (based on Documentation/CodingGuidelines) a space before the ternary conditional's colon. Then again, "git grep '?.*[^ ]:' *.[ch]" finds a few other cases with the unspaced style. -- D. Ben Knoble
