On Thu Jan 23, 2025 at 22:00, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Bence Ferdinandy <bence@xxxxxxxxxxxxxx> writes: > >> In b1b713f722 (fetch set_head: handle mirrored bare repositories, >> 2024-11-22) it was implicitly assumed that all remotes will be mirrors >> in a bare repository, thus fetching a non-mirrored remote could lead to >> HEAD pointing to a non-existent reference. Make sure we only overwrite >> HEAD if we are in a bare repository and fetching from a mirror. >> Otherwise, proceed as normally, and create >> refs/remotes/<nonmirrorremote>/HEAD instead. >> >> Signed-off-by: Bence Ferdinandy <bence@xxxxxxxxxxxxxx> >> Reported-by: Christian Hesse <list@xxxxxxxx> > > These should be chronological; somebody reports an issue, the patch > gets written, and finally it is sent out with a Sign-off to certify > that the patch is not a stolen property. Makes sense, I'll send a v2 in that case. > >> --- >> builtin/fetch.c | 15 ++++++++------- >> t/t5505-remote.sh | 10 ++++++++++ >> t/t5510-fetch.sh | 13 +++++++++++++ >> 3 files changed, 31 insertions(+), 7 deletions(-) > > We haven't heard from Chritian; has this been tested OK? To the extent of the tests I've added, but I'm not aware of anybody else, especially Christian trying it out. > > What the patch does does look sensible. Thanks. Thanks, Bence
