Kyle Lippincott <spectral@xxxxxxxxxx> writes: > On Fri, Oct 11, 2024 at 6:50 PM Karthik Nayak <karthik.188@xxxxxxxxx> wrote: >> >> We generally align consecutive macro definitions for better readability: >> >> #define OUTPUT_ANNOTATE_COMPAT (1U<<0) >> #define OUTPUT_LONG_OBJECT_NAME (1U<<1) >> #define OUTPUT_RAW_TIMESTAMP (1U<<2) >> #define OUTPUT_PORCELAIN (1U<<3) > > I like this change, thanks. Is there a way of apply clang-format for > *only* one rule/aspect? i.e. can we apply *only* this, and preserve > every other line? At first glance, I don't see a way of doing it. If > there was, I might recommend a whole series just to applying these > changes, but with how out of compliance much of the codebase is today, > that's not going to be feasible; we'd need to format it in a way that > we might not want (the current style), and then fix it, and that seems > counterproductive. > I think we can apply a single rule by specifying the rule over the CLI. Overall I think its best to take things iteratively. Also because 'clang-format' is a bit rough around the edges and we might discover some other changes needed.
Attachment:
signature.asc
Description: PGP signature
