On Mon, Oct 14, 2024 at 05:42:39PM -0400, Taylor Blau wrote: > On Mon, Oct 14, 2024 at 04:06:41PM +0200, Patrick Steinhardt wrote: > > +while test "$#" -ne 0 > > +do > > + suite="$1" > > + shift > > I'm perhaps nit-picking here, but I find: > > for suite in "$@" > do > ... > done > > to be much more readable than 'while test "$#" -ne 0' and 'shift' > above, since the for-loop variant does not need to mangle its arguments > with shift. It certainly is, yeah. I know that there was a reason to write it in this convoluted way... was it compatibility with non-Bash shells when there were spaces in the paths? I don't know, and I cannot find a case right now where it breaks. Will adapt accordingly. Patrick
