On Fri, Oct 11, 2024 at 6:50 PM Karthik Nayak <karthik.188@xxxxxxxxx> wrote: > > We generally align consecutive macro definitions for better readability: > > #define OUTPUT_ANNOTATE_COMPAT (1U<<0) > #define OUTPUT_LONG_OBJECT_NAME (1U<<1) > #define OUTPUT_RAW_TIMESTAMP (1U<<2) > #define OUTPUT_PORCELAIN (1U<<3) I like this change, thanks. Is there a way of apply clang-format for *only* one rule/aspect? i.e. can we apply *only* this, and preserve every other line? At first glance, I don't see a way of doing it. If there was, I might recommend a whole series just to applying these changes, but with how out of compliance much of the codebase is today, that's not going to be feasible; we'd need to format it in a way that we might not want (the current style), and then fix it, and that seems counterproductive. > > over > > #define OUTPUT_ANNOTATE_COMPAT (1U<<0) > #define OUTPUT_LONG_OBJECT_NAME (1U<<1) > #define OUTPUT_RAW_TIMESTAMP (1U<<2) > #define OUTPUT_PORCELAIN (1U<<3) > > So let's add the rule in clang-format to follow this. > > Signed-off-by: Karthik Nayak <karthik.188@xxxxxxxxx> > --- > .clang-format | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/.clang-format b/.clang-format > index 66a2360ae5..9547fe1b77 100644 > --- a/.clang-format > +++ b/.clang-format > @@ -32,6 +32,9 @@ AlignConsecutiveAssignments: false > # double b = 3.14; > AlignConsecutiveDeclarations: false > > +# Align consecutive macro definitions. > +AlignConsecutiveMacros: true > + > # Align escaped newlines as far left as possible > # #define A \ > # int aaaa; \ > -- > 2.47.0 >
