On Thu, Sep 05, 2024 at 11:42:45AM -0700, Junio C Hamano wrote:
> Patrick Steinhardt <ps@xxxxxx> writes:
>
> > On Thu, Sep 05, 2024 at 08:15:53PM +0530, Chandra Pratap wrote:
> >
> >> Should we get rid of reftable/test_framework.{c, h} as well?
> >
> > Ah, yeah. If it's not needed anymore we should remove it. I have a patch
> > series pending anyway where I deduplicate some of the functionality that
> > we have in multiple reftable tests now.
>
> It is unclear if you are saying that Chandra should do the removal
> as part of an updated version of this series, or you'll do the
> removal with refactoring in a separate series and Chandra shouldn't
> worry about it for now.
>
> After reading your message three times, I am leaning to take it as
> the latter.
Ah, sorry for being unclear.
The test framework used to contain some functions that were reused
across different reftable tests. During the migration we have instead
copied the necessary helpers into each of the migrated tests and thus
have a bit of duplication there, which was the right choice during the
migration to not have all migrations depend on each other. But now that
we are done we should deduplicate them again, and I have a patch series
pending that introduces `t/unit-tests/lib-reftable.c` that deduplicates
some of the functions again.
So my intention was to say that this is safe to remove as part of the
series we have here, and we do not have to worry about the current
duplication we have.
Patrick
