On Thu, 5 Sept 2024 at 12:45, Patrick Steinhardt <ps@xxxxxx> wrote: > > On Wed, Sep 04, 2024 at 10:17:47AM -0700, Junio C Hamano wrote: > > Chandra Pratap <chandrapratap3519@xxxxxxxxx> writes: > > > > > int cmd__reftable(int argc, const char **argv) > > > { > > > /* test from simple to complex. */ > > > - stack_test_main(argc, argv); > > > return 0; > > > } > > > > This makes cmd__reftable() a no-op. > > > > Even though you cannot remove t/helpter/test-reftable.c, as it > > contains the implementation for "test-tool dump-reftable", we should > > at least be able to do something like this. > > In addition to Junio's patch you can also remove > "reftable/reftable-tests.h". Should we get rid of reftable/test_framework.{c, h} as well?