Re: [PATCH v3 4/4] add-patch: render hunks through the pager

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v3 4/4] add-patch: render hunks through the pager
From: Rubén Justo <rjusto@xxxxxxxxx>
Date: Mon, 22 Jul 2024 16:53:59 +0200
Cc: phillip.wood123@xxxxxxxxx, Junio C Hamano <gitster@xxxxxxxxx>, Git List <git@xxxxxxxxxxxxxxx>, Dragan Simic <dsimic@xxxxxxxxxxx>, Jeff King <peff@xxxxxxxx>, Phillip Wood <phillip.wood@xxxxxxxxxxxxx>
In-reply-to: <CAPig+cR3BHMyuGOMYdbRxvMfNzZBGQjgsrJU4MOx-e67DOTsdQ@mail.gmail.com>
References: <2653fb37-c8a8-49b1-a804-4be6654a2cad@gmail.com> <ebcba08f-3fbb-4130-93eb-d0e62bfe0a8a@gmail.com> <efa98aec-f117-4cfe-a7c2-e8c0adbdb399@gmail.com> <1dc9ebad-768b-4c1a-8a58-8a7a5d24d49e@gmail.com> <xmqqttgqyzwa.fsf@gitster.g> <2b57479c-29c8-4a6e-b7b0-1309395cfbd9@gmail.com> <88f9256e-04ba-4799-8048-406863054106@gmail.com> <xmqqfrs723bp.fsf@gitster.g> <CAPig+cRyj8J7MZEufu34NUzwOL2n=w35nT1Ug7FGRwMC0=Qpwg@mail.gmail.com> <bc1b9cce-d04d-4a79-8fab-55ec3c8bae30@gmail.com> <CAPig+cR3BHMyuGOMYdbRxvMfNzZBGQjgsrJU4MOx-e67DOTsdQ@mail.gmail.com>
User-agent: Mozilla Thunderbird

On Mon, Jul 22, 2024 at 03:18:07AM -0400, Eric Sunshine wrote:

> I posted a series[2] which addresses this shortcoming by enhancing
> check-non-portable-shell.pl.

I tested this series with them, and it correctly detects the error.

Thanks for sending the improvement so quick!

References:
- [PATCH 0/4] use the pager in 'add -p'
  - From: Rubén Justo
- [PATCH v2 0/4] use the pager in 'add -p'
  - From: Rubén Justo
- [PATCH v3 0/4] use the pager in 'add -p'
  - From: Rubén Justo
- [PATCH v3 4/4] add-patch: render hunks through the pager
  - From: Rubén Justo
- Re: [PATCH v3 4/4] add-patch: render hunks through the pager
  - From: Junio C Hamano
- Re: [PATCH v3 4/4] add-patch: render hunks through the pager
  - From: Rubén Justo
- Re: [PATCH v3 4/4] add-patch: render hunks through the pager
  - From: phillip . wood123
- Re: [PATCH v3 4/4] add-patch: render hunks through the pager
  - From: Junio C Hamano
- Re: [PATCH v3 4/4] add-patch: render hunks through the pager
  - From: Eric Sunshine
- Re: [PATCH v3 4/4] add-patch: render hunks through the pager
  - From: Rubén Justo
- Re: [PATCH v3 4/4] add-patch: render hunks through the pager
  - From: Eric Sunshine

Prev by Date: Re: [PATCH 0/4] improve one-shot variable detection with shell function
Next by Date: Re: [PATCH 1/4] t3430: modernize one-shot "VAR=val shell-func" invocation
Previous by thread: Re: [PATCH v3 4/4] add-patch: render hunks through the pager
Next by thread: Re: [PATCH v3 4/4] add-patch: render hunks through the pager
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]