On 17/07/2024 21:03, Junio C Hamano wrote:
phillip.wood123@xxxxxxxxx writes:
- test_write_lines P q | GIT_PAGER="head -n 1" test_terminal git add -p
+ test_write_lines P q |
+ (
+ GIT_PAGER="head -n 1" &&
+ export GIT_PAGER &&
+ test_terminal git add -p >actual
+ )
That's surprising, why does running git in a sub-shell stop it from
segfaulting?
Yeah, it indeed is curious.
The rewrite resolves another iffy point in the original---you are
not supposed to attempt a one-shot assignment to the environment
variable when you are running a shell function, as that is not
portable. And the above rewrite is a common way to fix that.
Good point, I'd not thought of that.
Best Wishes
Phillip
