On Mon, Jul 22, 2024 at 02:59:10AM -0400, Eric Sunshine wrote: > From: Eric Sunshine <sunshine@xxxxxxxxxxxxxx> > > This series addresses a blind-spot of check-non-portable-shell's > detection of one-shot environment variable assignment with shell > functions. In particular, although it correctly detects: > > VAR=val shell-func > > it will miss invocations such as: > > echo X | VAR=val shell-func > > References: > https://lore.kernel.org/git/CAPig+cRyj8J7MZEufu34NUzwOL2n=w35nT1Ug7FGRwMC0=Qpwg@xxxxxxxxxxxxxx/ > https://lore.kernel.org/git/bc1b9cce-d04d-4a79-8fab-55ec3c8bae30@xxxxxxxxx/ > > Eric Sunshine (4): > t3430: modernize one-shot "VAR=val shell-func" invocation > t4034: fix use of one-shot variable assignment with shell function > check-non-portable-shell: improve `VAR=val shell-func` detection > check-non-portable-shell: suggest alternative for `VAR=val shell-func` All these changes look good to me. Thanks. > > t/check-non-portable-shell.pl | 4 ++-- > t/t3430-rebase-merges.sh | 4 ++-- > t/t4034-diff-words.sh | 2 +- > 3 files changed, 5 insertions(+), 5 deletions(-) > > -- > 2.45.2 >
