Re: [PATCH 4/4] Implement git commit and status as a builtin commands.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, 5 Nov 2007, Bj?rn Steinbrink wrote:

> On 2007.11.05 13:57:53 -0500, Kristian H?gsberg wrote:
>
> > The shell script just has
> > 
> > case "$all,$interactive,$also,$#" in
> > *t,*t,*)
> >         die "Cannot use -a, --interactive or -i at the same time." ;;
> > 
> > which doesn't seem to care about the value of $also.  As far as I 
> > understand git commit, it doesn't make sense to pass any of -a, -i, -o 
> > or --interactive at the same time so I guess I could join the checks
> 
> Note that there are only two commas. The asterisks catch everything and
> $# won't be "t", so that catches anything with at least two t's.

So shouldn't it be

	if (!!all + !!interactive + !!also > 1)

Hmm?

Ciao,
Dscho

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux