On Sat, 2007-11-03 at 16:06 +0100, Björn Steinbrink wrote:
> On 2007.11.02 11:33:09 -0400, Kristian Høgsberg wrote:
> > + if (all && interactive)
> > + die("Cannot use -a, --interactive or -i at the same time.");
>
> Shouldn't that be "if (all && (interactive || also))"?
The shell script just has
case "$all,$interactive,$also,$#" in
*t,*t,*)
die "Cannot use -a, --interactive or -i at the same time." ;;
which doesn't seem to care about the value of $also. As far as I
understand git commit, it doesn't make sense to pass any of -a, -i, -o
or --interactive at the same time so I guess I could join the checks
if (also && only)
die("Only one of --include/--only can be used.");
if (all && interactive)
die("Cannot use -a, --interactive or -i at the same
time.");
into something like
if (also + only + all + interactive > 1)
die("Only one of --include/--only/--all/--interactive can be used.");
Does that sound right?
Kristian
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
