Phillip Wood <phillip.wood123@xxxxxxxxx> writes: > Hi Junio > > On 08/02/2024 17:20, Junio C Hamano wrote: >> Phillip Wood <phillip.wood123@xxxxxxxxx> writes: >> >>> I think that typically for small suggestions like that we just add a >>> Helped-by: trailer but feel free to add my SOB if you want. >> Thanks, both. Here is what I assembled from the pieces. >> ----- >8 --------- >8 --------- >8 --------- >8 ----- >> From: Vegard Nossum <vegard.nossum@xxxxxxxxxx> >> Date: Fri, 2 Feb 2024 10:18:50 +0100 >> Subject: [PATCH] sequencer: unset GIT_CHERRY_PICK_HELP for 'exec' commands >> Running "git cherry-pick" as an x-command in the rebase plan loses >> the original authorship information. > > It might be worth explaining why this happens > > This is because rebase sets the GIT_CHERRY_PICK_HELP environment > variable to customize the advice given to users when there are > conflicts which causes the sequencer to remove CHERRY_PICK_HEAD. True. I'd prefer to see the original submitter assemble the pieces and come up with the final version, rather than me doing so. Thanks.