On Fri Jan 19, 2024 at 4:48 AM IST, Junio C Hamano wrote: > Ghanshyam Thakkar <shyamthakkar001@xxxxxxxxx> writes: > > - ( mkdir untarred && cd untarred && "$TAR" -xf ../test.tar ) && > > + mkdir untarred && > > + ( > > + cd untarred && > > + "$TAR" -xf ../test.tar > > + ) && > > I think we assume "$TAR" is modern enough to know about the "C" > option (see t/t5004-archive-corner-cases.sh), so > > mkdir untarred && > "$TAR" Cxf untarred test.tar > > without even a subshell may be sufficient. I suppose '"$TAR" Cxf untarred test.tar' is not a valid syntax on alpine, since it was breaking CI. Instead changed it to '"$TAR" xf test.tar -C untarred' in v3, which is how it's written in t/t5004-archive-corner-cases.sh, which passes CI.
