Ghanshyam Thakkar <shyamthakkar001@xxxxxxxxx> writes: > Refactor t0024 to avoid having multiple chaining commands on a single > line, according to current styling norms. > > e.g turn > ( mkdir testdir && cd testdir && echo "in testdir" ) > into: > mkdir testdir && > ( > cd testdir && > echo "in testdir" > ) > > This is also described in the Documentation/CodingGuidelines file. Sure. Subject: t0024: style fix t0024 has multiple command invocations on a single line, which goes against the style given by CodingGuidelines. would be sufficient. > - ( mkdir untarred && cd untarred && "$TAR" -xf ../test.tar ) && > + mkdir untarred && > + ( > + cd untarred && > + "$TAR" -xf ../test.tar > + ) && I think we assume "$TAR" is modern enough to know about the "C" option (see t/t5004-archive-corner-cases.sh), so mkdir untarred && "$TAR" Cxf untarred test.tar without even a subshell may be sufficient. > @@ -30,7 +34,11 @@ test_expect_success UNZIP 'zip archive' ' > > git archive --format=zip HEAD >test.zip && > > - ( mkdir unzipped && cd unzipped && "$GIT_UNZIP" ../test.zip ) && > + mkdir unzipped && > + ( > + cd unzipped && > + "$GIT_UNZIP" ../test.zip > + ) && I do not think we assume "$GIT_UNZIP" to always know about the equivalent of "C" (is that "-d exdir"?), so what you wrote is the best we can do. Thanks.
