On Fri Jan 19, 2024 at 4:48 AM IST, Junio C Hamano wrote: > > - ( mkdir untarred && cd untarred && "$TAR" -xf ../test.tar ) && > > + mkdir untarred && > > + ( > > + cd untarred && > > + "$TAR" -xf ../test.tar > > + ) && > > I think we assume "$TAR" is modern enough to know about the "C" > option (see t/t5004-archive-corner-cases.sh), so > > mkdir untarred && > "$TAR" Cxf untarred test.tar > > without even a subshell may be sufficient. Will update it in v2. > > > @@ -30,7 +34,11 @@ test_expect_success UNZIP 'zip archive' ' > > > > git archive --format=zip HEAD >test.zip && > > > > - ( mkdir unzipped && cd unzipped && "$GIT_UNZIP" ../test.zip ) && > > + mkdir unzipped && > > + ( > > + cd unzipped && > > + "$GIT_UNZIP" ../test.zip > > + ) && > > I do not think we assume "$GIT_UNZIP" to always know about the > equivalent of "C" (is that "-d exdir"?), so what you wrote is the > best we can do. Yeah, "-d exdir" would be the equivalent, but there's no mention of it in the testcases in t5003 or t5004. So, keeping it as is in v2. Thanks.
