On Thu, Sep 14, 2023 at 8:01 PM Taylor Blau <me@xxxxxxxxxxxx> wrote: > > On Thu, Sep 14, 2023 at 01:10:38PM +0200, Christian Couder wrote: > > Ok, I will try to review and merge this with > > cc/repack-sift-filtered-objects-to-separate-pack soon. > > I took a look at how much/little effort was going to be required, and > luckily the changes are isolated only to a single patch. It's just your > f1ffa71e8f (repack: add `--filter=<filter-spec>` option, 2023-09-11), > and in particular the `write_filtered_pack()` function. > > I started messing around with it myself and generated the following > fixup! which can be applied on top of your version of f1ffa71e8f. It's > mostly straightforward, but there is a gotcha that the loop over > non-kept packs has to change to: > > for_each_string_list_item(item, &existing->non_kept_packs) > /* ... */ > for_each_string_list_item(item, &existing->cruft_packs) > /* ... */ > > , instead of just the first loop over non_kept_packs, since cruft packs > are stored in a separate list. > > In any event, here's the fixup! I generated on top of that patch: Thanks a lot! I will very likely use it in the new version I will send after your series has graduated.
