On Fri, 30 Jun 2023 at 04:39, Emily Shaffer <nasamuffin@xxxxxxxxxx> wrote: > Yeah, I think there are two things to fix: > > First, a patch to Documentation/technical/MyFirstObjectWalk.txt fixing > the snippets there. (I thought that was what you were offering to > patch in your original mail, I may have been mistaken.) > > Second, optionally, a rebased-and-fixed-and-your-attribution-added > branch of the reference impl that I can force-push to nasamuffin/git. > The more I think on it, I don't think the PR will help, since I will > want to just force-push that whole branch so the commit order still > functions as a learning tool. So if you have it even in a branch on > your GitHub or GitLab fork, or a series of patches you'd want to mail > to me, any of those are fine and I'll go ahead and rewrite my branch. I will be pushing MyFirstObjectWalk's implementation to my Github fork, but I might need a day's time to do that(I don't want to leave behind any mistakes). You are right, a PR surely does not seem to be the best way to do this. As soon as I finish(shouldn't take too much time), I will reply with a link to the branch. Would that be alright? Thanks a lot! Vinayak
