On Thu, Jun 29, 2023 at 11:45 AM Vinayak Dev <vinayakdev.sci@xxxxxxxxx> wrote: > > > On Thu, Jun 29, 2023 at 9:33 AM Emily Shaffer <nasamuffin@xxxxxxxxxx> wrote: > > Hi, thanks for replying! > > > > Yeah, it's almost certainly stale in MyFirstObjectWalk - there was > > > very recently a patch to clean up some headers which probably were > > > implicitly including trace.h when I wrote this walkthrough. Patches > > > totally welcome - and if you were working from the reference code in > > > https://github.com/nasamuffin/git/tree/myfirstrevwalk > > > > bah, wrong link, the tutorial points to branch `revwalk` instead of > > `myfirstrevwalk`, but the offer stands :) > > > > > and it's on your > > > way to rebase and fix that too, I'm happy to update my branch > > > accordingly too. (If you weren't, don't worry about doing the extra > > > work, though.) > > Sure will! But do you mean open a PR on your fork? I have the patch ready, > and would be very happy to do so, if it is accepted! Yeah, I think there are two things to fix: First, a patch to Documentation/technical/MyFirstObjectWalk.txt fixing the snippets there. (I thought that was what you were offering to patch in your original mail, I may have been mistaken.) Second, optionally, a rebased-and-fixed-and-your-attribution-added branch of the reference impl that I can force-push to nasamuffin/git. The more I think on it, I don't think the PR will help, since I will want to just force-push that whole branch so the commit order still functions as a learning tool. So if you have it even in a branch on your GitHub or GitLab fork, or a series of patches you'd want to mail to me, any of those are fine and I'll go ahead and rewrite my branch. > > Thanks a lot! > Vinayak
