On Thu, Jun 29, 2023 at 9:06 AM Vinayak Dev <vinayakdev.sci@xxxxxxxxx> wrote: > > Hey there! > I was looking through Documentation/MyFirstObjectWalk.txt, and upon > building the branch containing the given code, I find that I get the > error that C99 does not allow implicit function declaration where > trace_printf() is encountered. However, upon including trace.h the > error disappears, and the build proceeds just fine. > > I did put DEVELOPER=1 in config.mak before building, but it doesn't > seem to work. > > Is the error pointing to a problem, or am I doing something wrong? > If it is the former, I would be very happy to send a patch fixing this. Yeah, it's almost certainly stale in MyFirstObjectWalk - there was very recently a patch to clean up some headers which probably were implicitly including trace.h when I wrote this walkthrough. Patches totally welcome - and if you were working from the reference code in https://github.com/nasamuffin/git/tree/myfirstrevwalk and it's on your way to rebase and fix that too, I'm happy to update my branch accordingly too. (If you weren't, don't worry about doing the extra work, though.) > > Thanks a lot! > Vinayak
