Re: [PATCH 1/2] builtin/sparse-checkout: remove NEED_WORK_TREE flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 8, 2023 at 11:27 AM Junio C Hamano <gitster@xxxxxxxxx> wrote:
>
> Junio C Hamano <gitster@xxxxxxxxx> writes:
>
> > But you did not find a place the feature you wanted to add with
> > [2/2] would fit better, perhaps, in which case, somebody else may be
> > able to suggest an alternative in their reviews of that step,
> > hopefully.
>
> ... oh, or perhaps the list would reach a consensus that mixing a
> subcommand that does not require a working tree is not all that bad,
> which I am personally OK with, too.  I didn't at all mean to say:
> "this shouldn't be a subcommand there, do it somewhere else".

I'm of the opinion that having sparse-checkout-related functionality
all fall under the 'sparse-checkout' command makes sense.  In the
past, all such subcommands happened to require a working tree, but
William has come up with a reasonable one that doesn't.  So, I'd be in
favor of this mixing.

I'll try to get a chance to review these patches soon, perhaps this weekend.




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux