On 23/01/06 09:34PM, Junio C Hamano wrote: > Jacob Abel <jacobabel@xxxxxxxxxx> writes: > > > On 22/12/29 03:49PM, Jacob Abel wrote: > >> > >> [...] > >> > >> So from my understanding of the situation, the only two options that pass all > >> the existing tests are either: > >> > >> A: Use the diff in [1] without the two quote example tests included. > >> > >> B: Revert the changes to how this was done in v5 [3]. > > ... > > Sorry to poke this but I wanted to confirm which path I should proceed with. > > Both options are functionally complete and it'd just be a matter of choosing > > which version to push out for the revision. > > I think B. with "$@" -> "$*" (because you only want a flattened > stringified version of the arguments in $opt to insert into the > test name string) would be the more sensible avenue. Let's not > over-engineer the tests---it is not the point of these new tests to > ensure that "git worktree add" can take arguments that require to be > quoted on the command line. > > Thanks. Perfect, Thank you. The revision should be out shortly.
