On 22/12/29 03:49PM, Jacob Abel wrote: > > [...] > > So from my understanding of the situation, the only two options that pass all > the existing tests are either: > > A: Use the diff in [1] without the two quote example tests included. > > B: Revert the changes to how this was done in v5 [3]. > > Both of these options work with me however option A will allow test authors to > easily escape quotes if new tests needed to be added at some point in the future. > > 1. https://lore.kernel.org/git/20221229063823.ij3jjuaar2fsayju@phi/ > 2. https://lore.kernel.org/git/xmqqsfhawwqf.fsf@gitster.g/ > 3. https://lore.kernel.org/git/20221220023637.29042-3-jacobabel@xxxxxxxxxx/ > 4. https://lore.kernel.org/git/221228.868risuf5x.gmgdl@xxxxxxxxxxxxxxxxxxx/ Sorry to poke this but I wanted to confirm which path I should proceed with. Both options are functionally complete and it'd just be a matter of choosing which version to push out for the revision.
