Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > The rest of this is all a result of applying [1]: > > * make contrib/coccinelle/run_command.cocci.patch > * patch -p1 <contrib/coccinelle/run_command.cocci.patch > * git add -u > > 1. cat contrib/coccinelle/run_command.pending.cocci > @@ > struct child_process E; > @@ > - E.env_array > + E.env > > @@ > struct child_process *E; > @@ > - E->env_array > + E->env It makes sense to have this in the log message for documentation purposes. We have plenty of examples of renaming a symbol to another, like the simple ones in object_id.cocci, so adding this to the collection in contrib/coccinelle would not add much value. Will replace. Thanks.
