On Wed, Dec 15 2021, Junio C Hamano wrote:
> * ab/make-dependency (2021-11-18) 24 commits
> - Makefile: move ".SUFFIXES" rule to shared.mak
> - Makefile: define $(LIB_H) in terms of $(FIND_SOURCE_FILES)
> - Makefile: disable GNU make built-in wildcard rules
> - Makefile: use $(file) I/O instead of "FORCE" when possible
> - Makefile: correct the dependency graph of hook-list.h
> - Makefiles: add and use wildcard "mkdir -p" template
> - Makefile: use $(wspfx) for $(QUIET...) in shared.mak
> - Makefile: add "$(QUIET)" boilerplate to shared.mak
> - Makefile: add a "TRACK_template" for GIT-*{FLAGS,DEFINES,...}
> - Makefile: re-add and use the "shellquote" macros
> - Makefile: move $(comma), $(empty) and $(space) to shared.mak
> - Makefiles: add "shared.mak", move ".DELETE_ON_ERROR" to it
> - Makefile: stop needing @@GIT_VERSION@@ in *.perl scripts
> - Makefile: create a GIT-PYTHON-DEFINES, like "PERL"
> - Makefile: correct "GIT-PERL-{DEFINES,HEADER}" dependency graph
> - Makefile: adjust Perl-related comments & whitespace
> - Makefile: change "ifndef NO_PERL" to "ifdef NO_PERL"
> - Makefile: guard Perl-only variable assignments
> - Makefile: remove "mv $@ $@+" dance redundant to .DELETE_ON_ERROR
> - Makefile: clean perl/build/ even with NO_PERL=Y
> - Makefile: use "=" not ":=" for po/* and perl/*
> - Makefile: don't set up "perl/build" rules under NO_PERL=Y
> - Makefile: don't invoke msgfmt with --statistics
> - Merge branch 'ab/sh-retire-helper-functions' into ab/make-dependency
>
> Dependency clean-up.
>
> Needs review.
> There are some comments on earlier rounds; the latest one needs a
> serious review or at least Acks from past commentors.
> source: <patch-v4-23.23-48a3927d972-20211117T101807Z-avarab@xxxxxxxxx>
I think it's best to drop this rather large topic for now.
I started re-rolling it with improvements to address your shell escaping
comments, and ended up with a much better end-state, but it's now at
north of 30 commits locally.
So I've split it up and have some incoming patches. Not for all of it,
just starting with some of the more urgent than not fixes & more trivial
& easy to review changes, or around 1/2 of what's quoted above.
I'll then submit the rest sometime after that lands.
