On Thu, May 5, 2022 at 9:15 AM Elijah Newren <newren@xxxxxxxxx> wrote: > > On Thu, May 5, 2022 at 8:56 AM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > [...] > > I vaguely recall there were folks who didn't like the change of > > default the last time you brought this topic up. Convincing them is > > not my job---it is yours. Mine has been to help prepare the code > > ready for public consumption when that happens. > > That's a surprise to me; I don't remember anyone bringing that up, > ever. Did I somehow miss it?? I'd be happy to talk to anyone and > hear their concerns if they do hold such an opinion. Over the last > year or so both Stolee and Victoria have suggested such a change or > said they wondered why I didn't include such a change with other > sparse-checkout changes we were making, and I mentioned a few times I > thought it'd be a good future plan and finally submitted it. To the > best of my memory, no one ever offered a counter opinion. > > Are you perhaps mixing this up with the case where people brought up > concerns with suggested tab-completion changes? That's the only other > related series recently where folks brought up concerns with suggested > changes. So, I did a few searches through the list history for anyone that may have commented on cone mode as default. The only comments I can find are Stolee, Victoria, Lessley, and I being in favor. Here's what I think is a pretty good search on lore.kernel.org/git[1]: "cone mode" default -f:stolee -f:gitster -f:newren -f:dye -f:dennington (Where the reason for the exclusions are because Stolee, Victoria, Lessley, and I have all spoken up in favor of the change, and you aren't stating that you're opposed to it just that you thought someone else had been. Plus those exclusions massively reduce the number of emails to read through, since I think we're the only active contributors to the sparse-checkout subcommand and related functionality.) Looking at all those links plus related discussion, the closest thing I could find was https://lore.kernel.org/git/20220118222234.GB2632@xxxxxxxxxx/ (which was later in the thread from [2] which was the direct link from the above search). However, this wasn't an argument against cone mode as default, that thread was where SZEDER argued that tab completion should not be limited to directories in non-cone mode[3]. Now, I did bring up making cone mode the default, but only in _response_ to that email because it'd handle his example _better_ than his hand-picked example of why he wanted completion to include files for non-cone mode. SZEDER didn't respond, which doesn't tell us much about his opinion on this area, but he certainly didn't push back on the suggestion to make cone mode the default. And that's the closest I can find to anyone stating a disagreement with this proposed change. Did I miss some other email in my searches that you remember where someone did actually have concerns with this change? [1] Quick link: https://lore.kernel.org/git/?q=%C2%A0%22cone+mode%22+default+-f%3Astolee+-f%3Agitster+-f%3Anewren+-f%3Adye+-f%3Adennington [2] https://lore.kernel.org/git/20220115095725.GA1738@xxxxxxxxxx/ [3] Though the example he used was perhaps unfortunate since it wasn't tab-completable with files anyway, and any completion that would have been provided by file completion would have been wrong since it'd complete on files in the wrong directory (namely, the root directory).
