Hi Abhradeep, On Fri, 25 Feb 2022, Abhradeep Chakraborty via GitGitGadget wrote: > From: Abhradeep Chakraborty <chakrabortyabhradeep79@xxxxxxxxx> > > `parse-options.c` doesn't check if the usage strings for option flags > are following the style guide or not. Style convention says, usage > strings should not start with capital letter (unless needed) and > it should not end with `.`. > > Add checks to the `parse_options_check()` function to check usage > strings against the style convention. As I just pointed out in https://lore.kernel.org/git/nycvar.QRO.7.76.6.2202251600210.11118@xxxxxxxxxxxxxxxxx/, it seems that replacing the static check presented in v1 by a runtime check needs to be reverted. In addition to the example I presented, there is another compelling reason to do so: with the static check, we can detect incorrect usage strings in all code, even in code that is platform-dependent (such as in `fsmonitor--daemon`). Ciao, Dscho
