Junio C Hamano <gitster@xxxxxxxxx> wrote: > Sorry that I've given you a trick question, when I know you are > quite new to the community. There is nothing to say `sorry`. Every review comment is teaching me new things. E.g. If you didn't ask me this question, I would not go to the codebase and see the proper handling of `xstrfmt`. So, thanks. > I think the right answer to "Do we care?" is "In this case, because > we are about to call exit(), we don't care. The extra complexity > and code necessary to retain the memory we get from xstrfmt and free > it is not worth it." It's not like we do this in a loop that iterates > unbounded number of times before the exit() happens (in which case > we should care). > > Thanks. Got it. Thanks :)
