Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: >> Add checks to the `parse_options_check()` function to check usage >> strings against the style convention. > > As I just pointed out in > https://lore.kernel.org/git/nycvar.QRO.7.76.6.2202251600210.11118@xxxxxxxxxxxxxxxxx/, > it seems that replacing the static check presented in v1 by a runtime > check needs to be reverted. Sorry, but I am not sure how that conclusion follows from a breakage in a topic in flight that was discovered by the check. I do not know if a coccinelle based solution is sufficiently easy, simple and robust enough to encourage us to scrap what has already been proposed and reviewed, instead of leaving it as a topic for a future incremental improvement that we can make on top. > In addition to the example I presented, there is another compelling reason > to do so: with the static check, we can detect incorrect usage strings in > all code, even in code that is platform-dependent (such as in > `fsmonitor--daemon`). Yes and no. I would imagine that large enough platforms that have their own conditionally compiled #ifdef/#endif block already have CI to build their conditionally compiled block in practice. I do not see the above as a compelling reason to grow and shift the scope of these two patches. Thanks.
