On Thu, Jan 13, 2022 at 9:00 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > >> Would make sense to steal the compiler version etc. details from my > >> <patch-1.1-7425b64c0a0-20220113T113821Z-avarab@xxxxxxxxx>. I.e. eventually > >> we'll be able to change this & other code back, as nobody will care > >> about that older compiler version. It worked before in the pre-image on > >> a more recent xlc. > > > > If so, wouldn't it be a better option not to worry about such an old > > compiler at all from the get-go? > > The above was a genuine question. If that "nobody will care about > the old compiler" will happen only after a few years, then it may > not work to just ignore the version of xlc which might still have > a meaningful number of users. I just am not in a good position to > judge that. I'm all for not worrying too much about ancient compilers, but there is no downside to this patch, so it seems fine to let this one go through. -- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
