On Fri, Jan 14, 2022 at 2:26 AM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > + ref.refname = ""; > > + ref.value_type = REFTABLE_REF_DELETION; > > + n = block_writer_add(&bw, &rec); > > + EXPECT(n == REFTABLE_API_ERROR); > > + > > The preimage of this hunk has been invalidated by your 9c498398 > (reftable: make reftable_record a tagged union, 2021-12-22). > > I see that the hn/reftable-coverity-fixes topic, which the commit is > a part of, has been expecting a reroll since last year---are you I sent a reroll on Jan 12. As that has had more scrutiny, it's best if that lands first. This series is less urgent. > plannning to rebuild that series after landing this series first? -- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado